Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IA-4996] WIP: Deploy Jupyter on AKS #4678

Draft
wants to merge 33 commits into
base: develop
Choose a base branch
from
Draft

[IA-4996] WIP: Deploy Jupyter on AKS #4678

wants to merge 33 commits into from

Conversation

lucymcnatt
Copy link
Collaborator

@lucymcnatt lucymcnatt commented Jun 28, 2024 •
edited
Loading

Jira ticket: https://broadworkbench.atlassian.net/browse/IA-4996

Dependencies

https://github.com/broadinstitute/terra-helmfile/pull/5659

Summary of changes

What

Why

Testing these changes

What to test

Who tested and where

  • This change is covered by automated tests
    • NB: Rerun automation tests on this PR by commenting jenkins retest or jenkins multi-test.
  • I validated this change
  • Primary reviewer validated this change
  • I validated this change in the dev environment

@lucymcnatt lucymcnatt changed the title [IA-4996] Deploy Jupyter on AKS: TEST! [IA-4996] WIP: Deploy Jupyter on AKS Jul 1, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.30120% with 62 lines in your changes missing coverage. Please review.

Project coverage is 73.69%. Comparing base (f9df012) to head (b43b9f5).
Report is 8 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #4678       +/-   ##
============================================
+ Coverage         0   73.69%   +73.69%     
============================================
  Files            0      161      +161     
  Lines            0    15079    +15079     
  Branches         0     1222     +1222     
============================================
+ Hits             0    11112    +11112     
- Misses           0     3967     +3967
Files Coverage Δ
...dsde/workbench/leonardo/auth/SamAuthProvider.scala 58.95% <100.00%> (ø)
...rkbench/leonardo/http/AppDependenciesBuilder.scala 97.88% <100.00%> (ø)
...te/dsde/workbench/leonardo/http/ConfigReader.scala 100.00% <ø> (ø)
...ch/leonardo/http/service/LeoAppServiceInterp.scala 86.96% <100.00%> (ø)
...h/leonardo/http/service/RuntimeServiceInterp.scala 87.54% <100.00%> (ø)
.../dsde/workbench/leonardo/util/GKEInterpreter.scala 59.97% <ø> (ø)
.../dsde/workbench/leonardo/util/GceInterpreter.scala 66.83% <ø> (ø)
...institute/dsde/workbench/leonardo/diskModels.scala 31.81% <0.00%> (ø)
...itute/dsde/workbench/leonardo/app/AppInstall.scala 22.22% <0.00%> (ø)
...orkbench/leonardo/config/KubernetesAppConfig.scala 97.87% <80.00%> (ø)
... and 7 more

... and 144 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9df012...b43b9f5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lucymcnatt